Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to ES modules #33

Merged
merged 1 commit into from
Sep 1, 2017
Merged

Migrate to ES modules #33

merged 1 commit into from
Sep 1, 2017

Conversation

vlad-zhukov
Copy link
Contributor

Closes #27

Current master:
22465 rambda.cjs.js
21044 rambda.esm.js
12483 rambda.umd.js

This PR:
18633 rambda.cjs.js
17541 rambda.esm.js
10932 rambda.umd.js

@vlad-zhukov
Copy link
Contributor Author

vlad-zhukov commented Aug 31, 2017

@selfrefactor it looks like you've tried to merge it, but something went wrong due to a conflict? I will fix the PR tomorrow so you can merge it.

Tests are passing in my PR. Jest automatically transpiles all files with Babel if there is a .babelrc file in the root directory, that's why I created it.

As a sidenote Travis runs a very outdated version of yarn (v0.17.8) but I've no idea how to fix it.

@selfrefactor
Copy link
Owner

selfrefactor commented Sep 1, 2017

Yep, we had the bad luck of working on the same time. I removed some tests that were using async keyword and were causing the build to fail.

I will stop pushing changes till you figure out a solution for this PR to be merged.

As for the outdated yarn on Travis - let's first merge the PR and then we'll think about that.

Once again, thanks again Vlad for the massive PR - it looks like you spend good 1-2 hours on that :)

Let me know if you need something from me in regards of merging this PR(in case that is still posible).

@vlad-zhukov vlad-zhukov mentioned this pull request Sep 1, 2017
@vlad-zhukov
Copy link
Contributor Author

It should be good to merge now. We should restore tests back to use async-await and test source files (rambda.js) instead of the CJS bundle.

@selfrefactor selfrefactor merged commit 2b5e149 into selfrefactor:master Sep 1, 2017
@vlad-zhukov vlad-zhukov deleted the es-modules branch September 1, 2017 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants