Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency execa to v8 #306

Merged
merged 2 commits into from
Sep 24, 2023
Merged

fix(deps): update dependency execa to v8 #306

merged 2 commits into from
Sep 24, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 19, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
execa ^7.0.0 -> ^8.0.0 age adoption passing confidence

Release Notes

sindresorhus/execa (execa)

v8.0.1

Compare Source

Fixes

v8.0.0

Compare Source

Breaking
  • Require Node.js 16.7.0 and later (#​569)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@travi
Copy link
Member

travi commented Aug 20, 2023

this doesnt fit with the currently supported engines definition for node. unlike most of the packages in the org, we've been more open to supporting lower node versions with this package because we know there are consumers outside of the org.

since this would be a breaking change and node v16 will be EOL in just a few months, i dont think we should change our minimum required node version without dropping v16 completely. since the EOL date is coming up, i think we should just wait for that date and realese a major version at that point. i could be convinced to jut go ahead and drop v16 now, but i dont think we need to rush.

@gr2m
Copy link
Member

gr2m commented Aug 20, 2023

since this would be a breaking change and node v16 will be EOL in just a few months, i dont think we should change our minimum required node version without dropping v16 completely. since the EOL date is coming up, i think we should just wait for that date and realese a major version at that point. i could be convinced to jut go ahead and drop v16 now, but i dont think we need to rush.

I agree, let's wait, and then drop Node 16 entirely.

@renovate renovate bot force-pushed the renovate/execa-8.x branch 3 times, most recently from 51fdec5 to f3452cc Compare August 29, 2023 15:35
BREAKING CHANGE: support of node versions v16 and v19 has been dropped
@renovate
Copy link
Contributor Author

renovate bot commented Sep 24, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@travi travi merged commit 2fdc486 into master Sep 24, 2023
5 checks passed
@travi travi deleted the renovate/execa-8.x branch September 24, 2023 13:57
@github-actions
Copy link

🎉 This PR is included in version 10.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants