Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: comment on issues and merge requests resolved by current release #332

Merged
merged 6 commits into from
Mar 20, 2022

Conversation

fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Feb 4, 2022

BREAKING CHANGE: By default all related issues and MRs are commented. Set the successComment option to false to disable that.

Fixes #40

🛠 with ❤ at Siemens

@fgreinacher fgreinacher changed the title Feat/comment issues feat: comment on issues resolved by current release Feb 4, 2022
@fgreinacher fgreinacher force-pushed the feat/comment-issues branch 9 times, most recently from f58ed63 to 79dd0d7 Compare February 6, 2022 11:43
@fgreinacher fgreinacher marked this pull request as ready for review February 6, 2022 11:49
@fgreinacher
Copy link
Contributor Author

fgreinacher commented Feb 6, 2022

OK, this is ready for review.

See https://gitlab.com/fgreinacher/semantic-release-comments/-/merge_requests/4 and its linked issues for a sample run from the current version of the this PR.

/cc @pvdlg @tmeijn @nfriend @joshdcomp as you have been active in the original issue.

@fgreinacher fgreinacher force-pushed the feat/comment-issues branch 2 times, most recently from 1a56987 to a443848 Compare February 6, 2022 11:55
README.md Outdated Show resolved Hide resolved
@tmeijn
Copy link

tmeijn commented Feb 6, 2022

@fgreinacher Awesome!

Two points of feedback I have:

  1. The issue that the Merge Request closes does necessarily lives in the same project that the Merge Request is merged in. Looking at code, it does not account for that case.
  2. Related to 1: the release is also not necessarily in the same project, so constructing a full url path should solve that case.

Thanks again!

@fgreinacher fgreinacher force-pushed the feat/comment-issues branch 2 times, most recently from 13ee743 to 3ee2273 Compare February 6, 2022 19:28
@fgreinacher
Copy link
Contributor Author

@fgreinacher Awesome!

Two points of feedback I have:

  1. The issue that the Merge Request closes does necessarily lives in the same project that the Merge Request is merged in. Looking at code, it does not account for that case.
  2. Related to 1: the release is also not necessarily in the same project, so constructing a full url path should solve that case.

Thanks again!

Good catch, thanks! I fixed this and also use the full release URL now.

@fgreinacher fgreinacher changed the title feat: comment on issues resolved by current release feat: comment on issues and merge requests resolved by current release Feb 7, 2022
@fgreinacher
Copy link
Contributor Author

@semantic-release I am not sure who is currently maintaining this repository. Could you help me find the right reviewer?

@fgreinacher
Copy link
Contributor Author

@travi Are you currently active here and would review this? 🙏

test/resolve-config.test.js Outdated Show resolved Hide resolved
@fgreinacher fgreinacher force-pushed the feat/comment-issues branch from 185045c to 3aa3a18 Compare March 18, 2022 15:52
@fgreinacher fgreinacher requested a review from travi March 19, 2022 13:24
@fgreinacher fgreinacher merged commit 4d0853b into semantic-release:master Mar 20, 2022
@github-actions
Copy link

🎉 This PR is included in version 7.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@fgreinacher
Copy link
Contributor Author

@travi Eek, seems the squash commit did not contain my breaking change trailer, making this 7.1.0 instead of 8.0.0 :/ Should I revert this for 7.1.1 and recommit with the correct message?

@travi
Copy link
Member

travi commented Mar 20, 2022

Yeah, that's the route that I would recommend. I've approved your draft PR for the revert.

I do wish that GitHub would do better with copying commit body details into the suggested squash message in situations like this.

@fgreinacher fgreinacher deleted the feat/comment-issues branch March 20, 2022 15:47
hvanoch pushed a commit to hvanoch/semantic-release-gitlab that referenced this pull request Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comment on issues resolved by current release
3 participants