Fixes log duplication issue #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscurtu
approved these changes
Apr 7, 2023
| if (canceled !== true) { | ||
| // The server shouldn't return NaN, but just in case and be defensive, | ||
| // we don't want to add NaN to the accumulatedLines. | ||
| if (!isNaN(pulledLines!)) { |
There was a problem hiding this comment.
I interpret that we want to log the isNaN case instead of !isNan. If so, a change is made as change.
augray
approved these changes
Apr 7, 2023
chance-an
force-pushed
the
c/bug_log_dup
branch
2 times, most recently
from
708a2e3 to
bdebd6e
Compare
jrcribb
pushed a commit
to jrcribb/sematic
that referenced
this pull request
Apr 9, 2024
A bug occurs when logs are already loading, and an accidental simultaneous scroll event triggers another log pull. The second pull will append the same logs twice. According to the previous work, we can already sequentialize the pulls using a queue. So the fix is to avoid the second pull being issued if we discovered from the first pull that there would be no more logs. This PR does such, and some extras: 1. Add more loggings to understand the async queuing and execution details 2. A helper function `useRefFn` to avoid the initial value of `useRef` being re-created multiple times across rendering. (see also [here](facebook/react#14490)) 3. Convert `AsyncInvocationQueue` from a function to a class to carry more responsibilities 4. Updated unit test accordingly. --------- Co-authored-by: tscurtu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug occurs when logs are already loading, and an accidental simultaneous scroll event triggers another log pull. The second pull will append the same logs twice.
According to the previous work, we can already sequentialize the pulls using a queue. So the fix is to avoid the second pull being issued if we discovered from the first pull that there would be no more logs.
This PR does such, and some extras:
useRefFnto avoid the initial value ofuseRefbeing re-created multiple times across rendering. (see also here)AsyncInvocationQueuefrom a function to a class to carry more responsibilities