Only detect Sauce API token if its a V4 GUID #3530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex already implicitly matched a GUID, but this makes it more strict. This solves false positives where another hexadecimal string follows "sauce", such as in yarn.lock files.
0xDC0DE
added a commit
that referenced
this pull request
Feb 7, 2025
* Add gcp sql rules for insecure ssl_mode (#3540) * Add gcp sql rules for insecure ssl_mode * clean up message and references --------- Co-authored-by: Lewis <[email protected]> * Only detect Sauce API token if its a V4 GUID (#3530) The regex already implicitly matched a GUID, but this makes it more strict. This solves false positives where another hexadecimal string follows "sauce", such as in yarn.lock files. * Update use-of-md5.yaml (#3557) --------- Co-authored-by: Pieter De Cremer (Semgrep) <[email protected]> Co-authored-by: Lewis <[email protected]> Co-authored-by: Sjoerd Langkemper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex already implicitly matched a GUID, but this makes it more strict. This solves false positives where another hexadecimal string follows "sauce", such as in yarn.lock files.