Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 330 #332

Merged
merged 2 commits into from
Jun 14, 2017
Merged

Fix issue 330 #332

merged 2 commits into from
Jun 14, 2017

Conversation

james-d-mitchell
Copy link
Collaborator

This PR fixes Issue #330.

James Mitchell added 2 commits June 14, 2017 16:47
attract: reformat InversesOfSemigroupElementNC
1e37114
attract: fix Issue 330 (InversesOfSemigroupElement)
52ae542 
If given a monoid, the previous method incorrectly only used the
generators of its argument as a monoid, hence getting the degree wrong,
not including the identity.
@james-d-mitchell james-d-mitchell changed the base branch from master to stable-3.0 June 14, 2017 15:53
@wilfwilson wilfwilson added the 3.0 label Jun 14, 2017
wilfwilson
wilfwilson approved these changes Jun 14, 2017
View reviewed changes
Copy link
Collaborator

@wilfwilson wilfwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant.

@wilfwilson wilfwilson merged commit baafd27 into semigroups:stable-3.0 Jun 14, 2017
@james-d-mitchell james-d-mitchell deleted the fix-issue-330 branch January 17, 2018 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilfwilson wilfwilson wilfwilson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@james-d-mitchell @wilfwilson