Fix NaturalPartialOrder method #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilfwilson
force-pushed
the
fix-issue-389
branch
from
3e45cf6 to
319d6ea
Compare
gap/attributes/attrinv.gi
Outdated
| p := Sortex(elts, IsGreensDGreaterThanFunc(S)) ^ -1; | ||
| func := function(x, y) | ||
| return IsGreensDGreaterThanFunc(S)(y, x); | ||
| end; |
There was a problem hiding this comment.
Can you use a 2-argument lambda here instead? p := Sortex(elts, {x, y} -> IsGreensDGreaterThanFunc(S)(y, x));?
wilfwilson
force-pushed
the
fix-issue-389
branch
from
319d6ea to
6bed8d9
Compare
wilfwilson
force-pushed
the
fix-issue-389
branch
from
6bed8d9 to
d72084d
Compare
Previously we pre-sorted the elements of the inverse semigroup by a Greens D > function, but we should use a Greens D < function. Resolves semigroups#389.
wilfwilson
force-pushed
the
fix-issue-389
branch
from
d72084d to
4b8c431
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #389.