Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add document to RAV storage adapter, adapter mod, tap_manager mod #132

Merged
merged 4 commits into from
Jul 10, 2023

Conversation

ColePBryan
Copy link
Contributor

No description provided.

@ColePBryan ColePBryan requested a review from aasseman July 6, 2023 21:45
@ColePBryan ColePBryan self-assigned this Jul 6, 2023
@ColePBryan ColePBryan linked an issue Jul 6, 2023 that may be closed by this pull request
@ColePBryan ColePBryan removed the request for review from severiano-sisneros July 6, 2023 21:45
@ColePBryan
Copy link
Contributor Author

NOTE: if reviewers want to see the generated docs, clone repo and run cargo doc --open

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Pull Request Test Coverage Report for Build 5480435125

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.067%

Totals Coverage Status
Change from base Build 5478449598: 0.0%
Covered Lines: 955
Relevant Lines: 1136

💛 - Coveralls

@github-actions

This comment has been minimized.

aasseman
aasseman previously approved these changes Jul 6, 2023
Copy link
Contributor

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aasseman aasseman added the documentation Improvements or additions to documentation label Jul 6, 2023
@ColePBryan ColePBryan force-pushed the 129-document-rav-storage-adapater branch from b16b89b to e689ac1 Compare July 7, 2023 23:58
@ColePBryan ColePBryan requested a review from aasseman July 7, 2023 23:59
@ColePBryan
Copy link
Contributor Author

@aasseman I just rebased with main and fixed an issue with the doc example code.

@github-actions
Copy link

github-actions bot commented Jul 8, 2023

🤖 Cargo Audit Report 🤖

(Empty means OK! 👍)

@ColePBryan
Copy link
Contributor Author

@aasseman btw it seems like the CI will pass cargo test without running doc tests. We might want to fix that to help ensure any example code stays up to date.

@aasseman
Copy link
Contributor

aasseman commented Jul 8, 2023

@aasseman btw it seems like the CI will pass cargo test without running doc tests. We might want to fix that to help ensure any example code stays up to date.

taiki-e/cargo-llvm-cov#2 😞

I'll add a workaround in the CI for this. The doc's code passes now, so no need to wait for that.

Copy link
Contributor

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ColePBryan ColePBryan merged commit a97898d into main Jul 10, 2023
@ColePBryan ColePBryan deleted the 129-document-rav-storage-adapater branch July 10, 2023 16:39
@ColePBryan ColePBryan linked an issue Jul 13, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document RAV storage adapter trait exhaustively (in code) Document RAV Storage Adapater
2 participants