-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add document to RAV storage adapter, adapter mod, tap_manager mod #132
Conversation
NOTE: if reviewers want to see the generated docs, clone repo and run |
Pull Request Test Coverage Report for Build 5480435125
💛 - Coveralls |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Bryan Cole <[email protected]>
Signed-off-by: Bryan Cole <[email protected]>
Signed-off-by: Bryan Cole <[email protected]>
Signed-off-by: Bryan Cole <[email protected]>
b16b89b
to
e689ac1
Compare
@aasseman I just rebased with main and fixed an issue with the doc example code. |
🤖 Cargo Audit Report 🤖 (Empty means OK! 👍) |
@aasseman btw it seems like the CI will pass cargo test without running doc tests. We might want to fix that to help ensure any example code stays up to date. |
I'll add a workaround in the CI for this. The doc's code passes now, so no need to wait for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.