Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc 1.4.20 #143

Merged
merged 9 commits into from
Aug 12, 2024
Merged

Rc 1.4.20 #143

merged 9 commits into from
Aug 12, 2024

Conversation

semuadmin
Copy link
Contributor

@semuadmin semuadmin commented Aug 5, 2024

PyGPSClient Pull Request Template

Description

FIXES:

  1. Fixes typo in ubx_handler which affects NAV2-STATUS messages #142

CHANGES:

  1. Minor improvements to settings frame appearance.
  2. Add support for logging in underlying pygnssutils utilities (gnssntripclient, gnssmqttclient, gnssserver)
  3. App get_coordinates() method now returns additional coordinate and fix data as dict rather than tuple.

Fixes #142

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.MD).
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain test coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin added bug Something isn't working enhancement New feature or request labels Aug 5, 2024
@semuadmin semuadmin added this to the RC 1.4.20 milestone Aug 5, 2024
@semuadmin semuadmin self-assigned this Aug 5, 2024
@semuadmin semuadmin marked this pull request as draft August 5, 2024 15:46
@semuadmin semuadmin marked this pull request as ready for review August 12, 2024 14:10
@semuadmin semuadmin merged commit 35c4b8e into master Aug 12, 2024
@semuadmin semuadmin deleted the RC-1.4.20 branch August 12, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typo in code
1 participant