Skip to content
This repository has been archived by the owner on Aug 20, 2020. It is now read-only.

docs: Add pull request template #34

Merged
merged 3 commits into from
Oct 27, 2017
Merged

docs: Add pull request template #34

merged 3 commits into from
Oct 27, 2017

Conversation

jeffgerlach
Copy link
Contributor

@jeffgerlach jeffgerlach commented Oct 26, 2017 •
edited
Loading

Add in example template from https://github.com/sendgrid/open-source-library-data-collector/blob/master/.github/PULL_REQUEST_TEMPLATE.md and updated for this project. First time contributing to open source, let me know if I missed anything! Closes #33

@SendGridDX
Copy link

SendGridDX commented Oct 26, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jeffgerlach jeffgerlach force-pushed the create_pull_request_template branch from d5497c5 to 0f4a60b Compare October 26, 2017 22:42
mbernier
mbernier suggested changes Oct 27, 2017
View reviewed changes
.github/PULL_REQUEST_TEMPLATE Outdated

If you have questions, please send an email [Sendgrid](mailto:[email protected]), or file a Github Issue in this repository.

<!--
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove this section? This is linking back to sendgrid/docs and may confuse people. I removed it from the source file too - sorry about that!

@mbernier
Copy link
Contributor

@jeffgerlach you did amazing! I made a mistake in my request, so I asked if you can make one small change for me. Please let me know if you have any issues and I will help out!

Thank you so much for making one of your first PRs with us!! We hope you learned something and enjoyed the experience (also once we get this merged, we'll send you a link to request a t-shirt!!)

@mbernier mbernier mentioned this pull request Oct 27, 2017
Closed
@jeffgerlach
Copy link
Contributor Author

Removed the section as you requested, let me know if there's anything else you'd like changed!

@mbernier mbernier merged commit 9e40b55 into sendgrid:master Oct 27, 2017
@thinkingserious
Copy link
Contributor

Hello @jeffgerlach,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@mbernier
Copy link
Contributor

Thanks @jeffgerlach!!

@thinkingserious thinkingserious changed the title Add pull request template docs: Add pull request template Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbernier mbernier mbernier approved these changes

Assignees
No one assigned
Labels
difficulty: easy hacktoberfest status: code review request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a PULL_REQUEST_TEMPLATE
4 participants
@jeffgerlach @SendGridDX @mbernier @thinkingserious