Skip to content
This repository has been archived by the owner on Aug 20, 2020. It is now read-only.

chore: added code climate config fixes #47 #48

Merged
merged 1 commit into from
Oct 28, 2017

Conversation

t2013anurag
Copy link
Contributor

Added code climate configuration.

The title should be descriptive, for example:
Fixes #47

Checklist

Make sure all of these items are complete, or else the PR will be ineligible for a code review.

  • Code passes all existing tests
  • Any new functionality added includes new unit tests in test/test.js
  • Create or update example code to show the new functionality in action.
  • All code, branch, and git naming and style conventions are followed (see CONTRIBUTING.md)
  • Feature branch has been rebased off of the latest master branch. ( see CONTRIBUTING.md ).

If you have questions, please send an email Sendgrid, or file a Github Issue in this repository.

@SendGridDX
Copy link

SendGridDX commented Oct 28, 2017

CLA assistant check
All committers have signed the CLA.

@t2013anurag
Copy link
Contributor Author

@thinkingserious - Codeclimate tests will fail because of eslint fixes.

Copy link
Contributor

@mbernier mbernier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, can you please make one more change? In this PR, @deanbrophy added some eslint configurations as well. Can you please add these as part of this PR as well?

@t2013anurag
Copy link
Contributor Author

@mbernier @thinkingserious - updated the PR.

@mbernier
Copy link
Contributor

Thank you!!!!!

@mbernier mbernier merged commit 426506f into sendgrid:master Oct 28, 2017
@thinkingserious
Copy link
Contributor

Hello @t2013anurag,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious changed the title added code climate config fixes #47 chore: added code climate config fixes #47 Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Add a .codeclimate.yml file to this repo
4 participants