Skip to content
This repository has been archived by the owner on Aug 20, 2020. It is now read-only.

chore: Closes #59 by adding a docker-compose file to spin up a container fr… #63

Merged
merged 2 commits into from
Nov 22, 2017

Conversation

onefastsnail
Copy link
Contributor

Closes #59

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

By adding a docker-compose file to spin up a container from which we can run tests through. Commented out related tests from #60 so tests would pass until such files are created. Updated the read me with some instructions.

…ainer from which we can run tests through. Commented out related tests from sendgrid#60 so tests would pass until such files are created. Updated the readme with some instructions.
@SendGridDX
Copy link

SendGridDX commented Oct 29, 2017

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

@onefastsnail

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@mbernier mbernier merged commit 758241f into sendgrid:master Nov 22, 2017
@thinkingserious
Copy link
Contributor

Hello @onefastsnail,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@mbernier
Copy link
Contributor

If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries.

Our agenda would be: Explore what you liked and is there anything we can do to improve?

You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer not to talk in person, please email me using my GitHub username at my company’s domain.

Thank you so much,

Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager
Elmer Thomas - @thinkingserious - SendGrid Developer Experience Engineer
@sendgrid

@thinkingserious thinkingserious changed the title Closes #59 by adding a docker-compose file to spin up a container fr… chore: Closes #59 by adding a docker-compose file to spin up a container fr… Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up a docker container
4 participants