Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): use ".default" named export when importing axios #1407

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tusharf5
Copy link

@tusharf5 tusharf5 commented Jul 5, 2024

Using this package with the latest axios with webpack results in an error, using a .default import which is officially supported by axios fixes that issue.

For more context, we are using sendgrid heavily at our org (tens of millions of emails per month) and upgrading to axios > 0 broke sendgrid and we narrowed it down to the import statement that's changed in this PR.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

@tusharf5 tusharf5 changed the title uses ".default" named export when importing axios fix(client): use ".default" named export when importing axios Jul 5, 2024
@naeemdadi-kunai
Copy link

+1

@naeemdadi-kunai
Copy link

Hey @tusharf5, thanks for this. Meanwhile have you found any alternative to solve this without downgrading to < 1?

@tusharf5
Copy link
Author

We use patch-package to update the package @naeemdadi-kunai

Shottr 2024-08-26 20 24 31

@naeemdadi-kunai
Copy link

We use patch-package to update the package @naeemdadi-kunai

Shottr 2024-08-26 20 24 31

Thank you @tusharf5, this is really helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants