Allow agents to have subscriptions defined as a resource #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treydock
force-pushed
the
subscriptions
branch
13 times, most recently
from
fb101c8 to
0b07244
Compare
ghoneycutt
reviewed
Mar 6, 2020
manifests/agent/subscription.pp
Outdated
| # Order of the datacat fragment | ||
| # | ||
| define sensu::agent::subscription ( | ||
| String $subscription = $name, |
There was a problem hiding this comment.
Should this be String[1] ?
There was a problem hiding this comment.
I made that change
ghoneycutt
reviewed
Mar 6, 2020
manifests/agent/subscription.pp
Outdated
| # | ||
| define sensu::agent::subscription ( | ||
| String $subscription = $name, | ||
| String $order = '50', |
There was a problem hiding this comment.
Should this also be String[1] or perhaps Integer?
There was a problem hiding this comment.
I used String[1] because doesn't need to be Integer and all docs for datacat use a string and the default in datacat is the string '50'.
|
Had to add updates to Ubuntu and Debian docker builds because bootstrapping Puppet was failing due to lack of HTTPS support in apt. Normally apt module would handle this but needed these packages in order to bootstrap Puppet. |
|
Great, I'll check it out. Good ol' datacat module 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
Allow subscriptions for agents to be defined in such a way that works like old Sensu module and plays well with defining subscriptions in profile classes for various resources.
The content of
agent.ymlis generated from fragments at runtime after catalog is compiled, unit tests can only test fragment data but acceptance tests are able to verify the final agent.yml content.Related Issue
Fixes #1222 and #1183
Motivation and Context
This makes it easier to dynamically generate
agent.ymlbased on profiles assigned to a given puppet host. Instead of having to hardcode subscriptions, subscriptions can be built based on profile classes assigned to a given host.