Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing invalid multibyte chars so it is 100% utf-8 #1237

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

mvsm
Copy link

@mvsm mvsm commented Mar 30, 2020

Pull Request Checklist

Just removed the non-utf8 chars.

Description

Removed non-utf8 chars from files:

  • sensu-puppet/lib/puppet/type/sensu_filter.rb
  • sensu-puppet/lib/puppet/type/sensu_hook.rb
  • sensu-puppet/lib/puppet/type/sensu_user.rb

Related Issue

#1235

Motivation and Context

Solves puppet catalog compilation and types generation.

General

Finished in 3 minutes 37.7 seconds (files took 2 minutes 7.7 seconds to load)
4343 examples, 0 failures

Finished in 3 minutes 37.7 seconds (files took 2 minutes 7.7 seconds to load)
4343 examples, 0 failures

@ghoneycutt
Copy link
Collaborator

ghoneycutt commented Mar 30, 2020

Thanks @mvsm

@treydock could you please create a separate PR that adds a check that occurs during the unit stage that ensures we do not have regressions of the same problem.

@treydock
Copy link
Collaborator

@ghoneycutt This issue was in comments, not code. I can't unit test that. I think this could have been old Puppet issue maybe because we run Debian acceptance tests with UTF-8 locales and puppetserver and never saw this. I honestly have no idea how to test for this.

@mvsm
Copy link
Author

mvsm commented Mar 30, 2020

I will try to add the tests.

@ghoneycutt ghoneycutt merged commit c4b361f into sensu:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants