Fix Windows acceptance tests and update Postgresql dependency range #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treydock
changed the title
ghoneycutt
reviewed
May 24, 2020
…e to this module by adding to metadata.json
|
For postgresql change, removed unnecessary soft dependency mention in README and also removed part in acceptance test setup as there is logic to automatically install modules in metadata.json, so those changes reduce duplication. |
ghoneycutt
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
Use latest Sensu Go for testing which is what happens when chocolatey tests run. This should resolve failures with appveyor as I ran the tests locally in Vagrant and had no issues. Also fix version test because now the version is more than just
5.20.0it's like5.20.0+eewhich we fixed for Travis tests but missed Windows.