Improved handling of changes to sensu::etc_dir #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treydock
force-pushed
the
etc_dir
branch
2 times, most recently
from
229cb8b to
bf0923e
Compare
ghoneycutt
requested changes
Oct 23, 2020
|
The tests in this PR will continue to fail until #1281 is merged and this is rebased with those changes. |
ghoneycutt
approved these changes
Oct 23, 2020
ghoneycutt
reviewed
Oct 23, 2020
ghoneycutt
reviewed
Oct 23, 2020
|
Added a lint knit since you have to rebase anyhow. |
|
This PR was rebased with fixes from #1281 |
treydock
force-pushed
the
etc_dir
branch
5 times, most recently
from
676caf5 to
391223b
Compare
This handling only works with systemd based sytems, adds dependency on campotcamp/systemd Fix unit tests to work with latest Puppet 6 release
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
Add support for changing
etc_dirin thesensuclass. Previously changing that value would move configs but not tell the Sensu daemons where to find the configs.This handling only works with systemd based sytems, adds dependency on campotcamp/systemd
Added a few improvements to documentation around
sensuclass and how to properly ensure agents can communicate with backend API.