Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option in scripts/serve.js. Updated INSTALL.MD documentation #367

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Added option in scripts/serve.js. Updated INSTALL.MD documentation #367

merged 1 commit into from
Mar 3, 2021

Conversation

thisgarryhas2rs
Copy link
Contributor

What is this change?

Adding a option through an environment variable (NODE_PROXY_SECURE) to set "secure: false" in the proxy config in the serve.js file. If the environment variable is not set it will default to "secure: true"

Why is this change necessary?

Current config requires a CA signed SSL certificate even in a development environment.

Have you reviewed and updated the documentation for this change? Is new documentation required?

Yes, I have updated the INSTALL.MD file.

How did you verify this change?

Deployed open source sensu web with my changes in my testing enviroment. The 500 error I was seeing no longer appeared after the change and I was allowed to connect to the sensu-backend service.

Related Issue

#362

@jamesdphillips jamesdphillips merged commit 3039a83 into sensu:master Mar 3, 2021
@jamesdphillips
Copy link
Contributor

@thisgarryhas2rs thanks for the contribution!

@thisgarryhas2rs thisgarryhas2rs deleted the secure_proxy_option branch March 3, 2021 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants