Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger Updated #182

Merged
merged 13 commits into from
Nov 4, 2024
Merged

Logger Updated #182

merged 13 commits into from
Nov 4, 2024

Conversation

sadrasabouri
Copy link
Collaborator

What does this implement/fix? Explain your changes.

Changed

  • logger function format for erdos_reyni_gilbert changed
  • log function added

@sadrasabouri sadrasabouri added this to the pyrgg 1.6 milestone Oct 13, 2024
@sadrasabouri sadrasabouri self-assigned this Oct 13, 2024
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.95%. Comparing base (56099e0) to head (ed9f90d).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #182      +/-   ##
==========================================
+ Coverage   98.90%   98.95%   +0.06%     
==========================================
  Files           7        7              
  Lines         545      571      +26     
  Branches       89       82       -7     
==========================================
+ Hits          539      565      +26     
  Misses          3        3              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pyrgg/functions.py Outdated Show resolved Hide resolved
pyrgg/engines/pyrgg.py Outdated Show resolved Hide resolved
Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sadrasabouri
Take a look at my comments 💯

CHANGELOG.md Outdated Show resolved Hide resolved
pyrgg/engines/pyrgg.py Outdated Show resolved Hide resolved
@sadrasabouri
Copy link
Collaborator Author

Comments are fixed, sorry for missing the pyrgg engine's f-format. Please re-review again @sepandhaghighi

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Owner

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@sepandhaghighi sepandhaghighi merged commit e9a6262 into dev Nov 4, 2024
27 checks passed
@sepandhaghighi sepandhaghighi deleted the logger branch November 4, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants