Feature/simd load #1018
Closed
Feature/simd load #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1018 +/- ##
==========================================
+ Coverage 96.42% 96.42% +<.01%
==========================================
Files 185 185
Lines 6714 6717 +3
==========================================
+ Hits 6474 6477 +3
Misses 240 240
Continue to review full report at Codecov.
|
|
@marehr can u review this? |
marehr
reviewed
May 29, 2019
| else if constexpr (simd_traits<simd_t>::max_length == 1) // scalar value? | ||
| return simd_t{*reinterpret_cast<simd_t const *>(mem_addr)}; | ||
| else | ||
| static_assert(simd_traits<simd_t>::max_length >= 1 && simd_traits<simd_t>::max_length, |
There was a problem hiding this comment.
simd_traits<simd_t>::max_length is weird.
| using simd_type = simd_type_t<int16_t>; | ||
|
|
||
| std::array<int16_t, simd_traits<simd_type>::length> mem{}; | ||
| simd_type expect{}; |
There was a problem hiding this comment.
Suggested change
| simd_type expect{}; | |
| simd_type expect = iota<simd_type>(0); |
| for (int16_t i = 0; i < static_cast<int16_t>(mem.size()); ++i) | ||
| { | ||
| mem[i] = i; | ||
| expect[i] = i; |
|
superseded by #1190 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds load function for simd.
Tested with sse4, avx2 and avx512.