Disable Rails/ContentTag #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubocop enforces #tag instead of #content_tag even though they are not the same right now, with crucial differences. More info: rubocop/rubocop-rails#260
mariozugaj
approved these changes
Feb 18, 2021
zaraheath
approved these changes
Feb 18, 2021
jaimevelaz
approved these changes
Feb 18, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Rubocop enforces
#taginstead of#content_tageven though they are not the same right now, with crucial differences.Issue in Rubocop suggesting it shouldn’t enforce the change in all cases:
rubocop/rubocop-rails#260
PR that disables the cop in the Foreman Ansible repo:
Incident in Timon
We’ve updated the merchant
/editform with a few changes because we have moved some limits configuration from one place of the DB to another.When creating a new method that renders a field, Rubocop told us to use
#taginstead of#content_tag(because they are similar in the latest version of Rails)… and we did.This broke the merchant /edit form, nesting fields inside fields inside fields.
This commit ended up fixing the problem: https://github.com/sequra/timon/commit/54b033e0b1a9e527e3ab0d207638b7010ce55349