Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for packed structs. #1791

Merged
merged 1 commit into from
May 10, 2020
Merged

Add support for packed structs. #1791

merged 1 commit into from
May 10, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 1, 2020

Fixes: #1747

@ghost ghost force-pushed the packed branch from cacfdc3 to 5b05088 Compare May 9, 2020 08:32
@ghost
Copy link
Author

ghost commented May 9, 2020

@dtolnay I force-pushed to trigger the new checks. Seems to pass.

dtolnay
dtolnay requested changes May 10, 2020
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

serde_derive/Cargo.toml Outdated Show resolved Hide resolved
@ghost ghost force-pushed the packed branch from 5b05088 to 19a7029 Compare May 10, 2020 05:30
dtolnay
dtolnay approved these changes May 10, 2020
View reviewed changes
Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dtolnay dtolnay merged commit 9f47c47 into serde-rs:master May 10, 2020
@dtolnay
Copy link
Member

dtolnay commented May 10, 2020

Published in 1.0.110.

@ghost ghost mentioned this pull request May 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Derive a Serialize implementation that works with packed structs
2 participants
@dtolnay @05storm26