Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower NetStandard Version #8

Closed
kvpt opened this issue Aug 9, 2016 · 2 comments
Closed

Lower NetStandard Version #8

kvpt opened this issue Aug 9, 2016 · 2 comments

Comments

@kvpt
Copy link
Contributor

kvpt commented Aug 9, 2016

Hi,

Is it possible to lower .NetStandard version to target .NetStandard 1.3, like in the two others enrichers ?

The only dependency is System.Runtime.Extensions which is available from .NetStandard 1.1, so it should be possible.

Thanks.

@nblumhardt
Copy link
Member

Hi @kvpt - thanks for the note.

Although we don't list all of the dependencies in project.json, we transitively get access to all of the Serilog dependencies for netstandard1.3 and thus have access to the environment. I am reasonably sure it's missing from < 1.3, but if you do manage to get it (or a substitute) working we'd love to hear about it and would accept a PR.

@kvpt
Copy link
Contributor Author

kvpt commented Aug 10, 2016

I made a local project to verify and I can confirm it works in .NetStandard 1.3 without problem.
I added the missing test and made a pull request.
The units tests are ok.

nblumhardt added a commit that referenced this issue Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants