Update to Serilog 3 and update TFMs #55
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usual question about TFMs to target that pop up in all the repos - should it be a complete match for Serilog 3.0, or a smaller set of what's needed?
In this draft:
Both Framework 4.6.2 and 4.7.1 to create an explicit reference to the 4.7.1 version of the core lib that doesn't depend on the System.ValueTuple nuget package
.NET 6 as the oldest supported .NET Core version, and to explicity use the .NET Core versions of the Serilog core lib (avoids the dependencies on System.Diagnostics.DiagnosticSource in the latest versions
.NET Standard 2.0 for everything else.
So question - is there a need for .NET Standard 2.1 / NET 5.0/7.0 etc?
Note: The TFMs in the unit test project are just set to match the core Serilog lib