-
Notifications
You must be signed in to change notification settings - Fork 28
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Chore] Update the rewrite rules for
text
Problem: after `2.0.1` version they rewrote `pack` completely, so now our tricks with folding `pack`/`unpack`'s internals do not work. For details, see [this commit in `text` package](haskell/text@5a666e4). Fortunately, annihilating entire `pack` and `unpack` calls is still an option. Along with that `pack` rewrite they added `NOINLINE [0]` pragma for `pack`, meaning that we have even better chances of the rewrite rule to fire. Solution: add a `MIN_VERSION` pragma to disable the now non-working rewrite rule in the recent `text` versions. Rely on the remaining `unpack (pack s) = s` and `pack (unpack s) = s` rewrite rules to fire at stage 0. Update maintenance notes, in the new reality verifying whether `text` bump is correct should be simpler.
- Loading branch information
1 parent
1f840f0
commit 8049813
Showing
1 changed file
with
27 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters