-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#290] Add Universum.Lens
module
#291
base: master
Are you sure you want to change the base?
Conversation
Problem: As in #290, we want to export lens-related operators like `(^.)` or `(^?)`, but we don't want to depend on `microlens` or `lens`. Solution: Implement those operators by ourselves, export them in a separate module to avoid names conflict. Remove those operators from `Universum` reexports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It looks like you partially deleted deprecated stuff. I propose to delete all deprecated
microlens
stuff in this PR (ideally in a separate commit). AFAIU you deleted it because otherwiseUniversum.Lens
is unusable (it conflicts withUniversum
itself). So we can't addUniversum.Lens
without deleting some deprecated things, so we can't put it into 1.8.x release. So we'll need to put it into 1.9.0, and it would be strange to make 1.9.0 without deleting allmicrolens
things. - Since everything in
Universum.Lens
is now defined manually, I think tests are needed. - Also the changelog should be updated.
Do we want to have What about
Ok will add this week |
AFAIU they won't be compatible with functions from But my main point was that currently the code in this branch hardly makes sense: the main point of adding |
Yes I was going to delete them after we'd agree to do so. Let's keep the current exports from |
I should not change any version tags, right? We must be sure no |
Yep, don't change the version, but please write about this change in |
Description
Problem:
As in #290, we want to export lens-related operators like
(^.)
or(^?)
, but we don't want to depend onmicrolens
orlens
.Solution:
Implement those operators by ourselves, and export them in a separate module to avoid name conflicts.
Remove those operators from
Universum
reexports.Related issues(s)
Fixed #290
✓ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).
are inextricably linked. Otherwise I should open multiple PR's.
I checked whether these changes impact the
.hlint.yaml
rulesand updated them if needed.
Related changes (conditional)
Tests
silently reappearing again.
Documentation
I checked whether I should update the docs and did so if necessary:
Record your changes
Unreleased
section if necessary) if my changes are visible to the usersand
Stylistic guide (mandatory)
My commit history is clean (only contains changes relating to my
issue/pull request and no reverted-my-earlier-commit changes) and commit
messages start with identifiers of related issues in square brackets.
Example:
[#42] Short commit description
If necessary both of these can be achieved even after the commits have been
made/pushed using rebase and squash.
✓ Release Checklist
universum.cabal
.under the "Unreleased" section to a new section for this release version.
I added
@since
haddock annotations.with a summary of all user-facing changes.
vX.Y.Z