This repository has been archived by the owner on Mar 20, 2024. It is now read-only.
More logging in debug mode #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanhs
force-pushed
the
aphs-logging
branch
from
4565461 to
3a2294d
Compare
aidanhs
force-pushed
the
aphs-logging
branch
from
3a2294d to
c5e274e
Compare
|
r? @Manishearth or @edunham |
Manishearth
approved these changes
Sep 23, 2017
homu/main.py
Outdated
| @@ -370,7 +371,7 @@ def verify_auth(username, repo_cfg, state, auth, realtime, my_username): | |||
| else: | |||
| reply += 'Not in reviewers' | |||
| elif auth == AuthState.TRY: | |||
| reply += 'and not in try users' | |||
| reply += 'and not in try users' | |||
|
Made change to error message. |
|
@bors-servo: r=manishearth |
|
📌 Commit 9679cd3 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 24, 2017
More logging in debug mode
This is probably excessively verbose (the `{!r}` prints out a lot of irrelevant info), but it's an improvement on the extreme lack at the moment.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/homu/133)
<!-- Reviewable:end -->
|
💔 Test failed - status-travis |
|
|
That seems like a new addition to flake8 that is hitting preexisting cases, unfortunately. |
bors-servo
pushed a commit
that referenced
this pull request
Oct 26, 2017
remove bare excepts for flake8 Bandaid for the bug which was hit in #133 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/homu/138) <!-- Reviewable:end -->
|
@bors-servo: retry |
bors-servo
pushed a commit
that referenced
this pull request
Oct 26, 2017
More logging in debug mode
This is probably excessively verbose (the `{!r}` prints out a lot of irrelevant info), but it's an improvement on the extreme lack at the moment.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/homu/133)
<!-- Reviewable:end -->
|
💔 Test failed - status-travis |
|
☀️ Test successful - status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably excessively verbose (the
{!r}prints out a lot of irrelevant info), but it's an improvement on the extreme lack at the moment.This change is