Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement URL spec changes regarding 'percent encode fragments' #246

Closed
frewsxcv opened this issue Dec 9, 2016 · 3 comments
Closed

Implement URL spec changes regarding 'percent encode fragments' #246

frewsxcv opened this issue Dec 9, 2016 · 3 comments

Comments

@frewsxcv
Copy link
Contributor

frewsxcv commented Dec 9, 2016

https://twitter.com/urlstandard/status/807279430490058752

whatwg/url#150

whatwg/url#169
@frewsxcv
Copy link
Contributor Author

frewsxcv commented Dec 9, 2016 •
edited
Loading

Maybe this should be folded into #163? ¯\_(ツ)_/¯

@valenting
Copy link
Collaborator

@Manishearth @SimonSapin This is blocking url-oxidation.

Manishearth added a commit to Manishearth/rust-url that referenced this issue Dec 10, 2016
@Manishearth
Percent-encode fragments based on whatwg/url#169
a3e8a6d 
fixes servo#246
@Manishearth Manishearth mentioned this issue Dec 10, 2016
Merged
@Manishearth
Copy link
Member

Fix in #248

bors-servo pushed a commit that referenced this issue Dec 15, 2016
Auto merge of #248 - Manishearth:percent-fragment, r=SimonSapin
37fe8a7 
Percent-encode fragments while parsing

Based on whatwg/url#169

Fixes #246

cc @valenting

r? @SimonSapin

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/248)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@frewsxcv @valenting @Manishearth