Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for crate evaluation #319

Closed
17 of 19 tasks
brson opened this issue May 4, 2017 · 6 comments
Closed
17 of 19 tasks

Tracking issue for crate evaluation #319

brson opened this issue May 4, 2017 · 6 comments

Comments

@brson
Copy link
Contributor

brson commented May 4, 2017 •
edited by KiChjang
Loading

This is the tracking issue for the crate evaluation performed by the libs team this week.

cc @rust-lang/libs
@theduke
Copy link

theduke commented May 13, 2017

Probably relevant: #338

@rap2hpoutre
Copy link
Contributor

Except for #304 #308 #314 and #317 everything seems to be fixed now. Maybe we should update the tracking message above @brson?

@brson
Copy link
Contributor Author

brson commented Jul 6, 2017

I updated the op. Thanks @rap2hpoutre

@rap2hpoutre rap2hpoutre mentioned this issue Jul 17, 2017
Merged
bors-servo pushed a commit that referenced this issue Jul 17, 2017
Auto merge of #382 - rap2hpoutre:master, r=SimonSapin
b8d3c15 
add more documentation for errors

More documentations for errors.  See #319 and #379

_Side question: I don't know how to document errors when a function returns `Result<(), ()>` so I did not document that part. I would be happy to see one example._

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/382)
<!-- Reviewable:end -->
@KodrAus
Copy link

KodrAus commented Jul 31, 2017

Looks like the only outstanding issue now is Move serde 1.0 support in-crate

@SimonSapin
Copy link
Member

Which is semi-blocked on serde-rs/serde#953.

@SimonSapin
Copy link
Member

Serde 1.0 support is tracked separately, so it seems this issue as served it purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@brson @theduke @SimonSapin @rap2hpoutre @KodrAus