Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace lazy_statics with std::sync::LazyLocks #314

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Replace lazy_statics with std::sync::LazyLocks #314

merged 2 commits into from
Sep 5, 2024

Conversation

jschwe
Copy link
Member

@jschwe jschwe commented Sep 5, 2024

  • Remove one instance of a useless lazystatic (Mutex::new() is const since Rust 1.63)
  • Replace remaining instances with LazyLock and Once from the standard library as appropriate.
  • Removes the lazylock dependency.

@jschwe
Remove needless lazy_static
9e4da18 
Mutex::new() is available in const contexts since Rust 1.63, so
no lazy_static is needed.
@jschwe
Replace lazy_statics with std::sync::LazyLock
8b4de77
@jschwe jschwe mentioned this pull request Sep 5, 2024
Merged
@mrobinson mrobinson added this pull request to the merge queue Sep 5, 2024
Merged via the queue into servo:main with commit 83c1d08 Sep 5, 2024
17 checks passed
@jschwe jschwe deleted the jschwender/replace_lazystatic branch September 5, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wusyong wusyong wusyong approved these changes

@mrobinson mrobinson mrobinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jschwe @mrobinson @wusyong