fix: Make StringMap.Merge, StringMap.Without always return a new map, as documented. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, StringMap.Merge(nil, x) would return x, not a new map. Improve the tests to catch this. While at it, clarify and fix some of the docstrings.
rudo-thomas
force-pushed
the
rudo-fix-stringmap-merge
branch
from
8d6b2a2 to
c26b0d7
Compare
FUSAKLA
approved these changes
Aug 26, 2021
rudo-thomas
changed the title
Yes. I've also caught this in |
|
Still 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously:
StringMap.Merge(nil, x)would return thex, not a new mapStringMap.Without(x, nil)would return thex, not the new map -- when x itself was not nil.Improve the tests to catch this.
While at it, clarify and fix some of the docstrings.
make e2e-testspasses.