Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prometheus_ingester: add staleness handling and allow shorter update interval #80

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

FUSAKLA
Copy link
Contributor

@FUSAKLA FUSAKLA commented Jan 5, 2022

fixes #74

WIP solution of the reported issue

@FUSAKLA FUSAKLA self-assigned this Jan 5, 2022
@FUSAKLA FUSAKLA marked this pull request as draft January 10, 2022 19:30
@FUSAKLA FUSAKLA marked this pull request as ready for review January 11, 2022 08:22
@FUSAKLA FUSAKLA requested a review from david-vavra January 11, 2022 08:23
@FUSAKLA
Copy link
Contributor Author

FUSAKLA commented Jan 11, 2022

@david-vavra PTAL, I'll still do some manual testing but it looks promising

docs/modules/prometheus_ingester.md Outdated Show resolved Hide resolved
docs/modules/prometheus_ingester.md Outdated Show resolved Hide resolved
pkg/prometheus_ingester/query_executor.go Outdated Show resolved Hide resolved
@FUSAKLA
Copy link
Contributor Author

FUSAKLA commented Jan 18, 2022

@david-vavra PTAL sorry about that Markdown formatting, I reverted those changes, so the docs should be also reviewable

@david-vavra
Copy link
Contributor

Great, thanks. 👍

@FUSAKLA FUSAKLA merged commit bfbf52d into master Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] incorrect increase calculation in prometheus_ingester
2 participants