Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prometheusIngester now can send custom headers to prometheus api #94

Merged
merged 9 commits into from
Oct 6, 2022
Merged

feat: prometheusIngester now can send custom headers to prometheus api #94

merged 9 commits into from
Oct 6, 2022

Conversation

FuFikCZ
Copy link
Contributor

@FuFikCZ FuFikCZ commented Sep 12, 2022

Introducing possibility to send headers to prometheus api server in prometheusIngester module.

Motivation:

  • mimir query requires X-Scope-OrgID to be send to server
  • our stack has envoy proxy infron of queryer which handles authentication based on http headers

rudo-thomas
rudo-thomas requested changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@rudo-thomas rudo-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX stuff + Go nits.

pkg/prometheus_ingester/prometheus_ingester.go Outdated Show resolved Hide resolved
pkg/prometheus_ingester/prometheus_ingester.go Outdated Show resolved Hide resolved
pkg/prometheus_ingester/prometheus_ingester.go Outdated Show resolved Hide resolved
pkg/prometheus_ingester/prometheus_ingester_test.go Outdated Show resolved Hide resolved
pkg/prometheus_ingester/headerRoundTripper.go Outdated Show resolved Hide resolved
pkg/prometheus_ingester/headerRoundTripper.go Outdated Show resolved Hide resolved
pkg/prometheus_ingester/headerRoundTripper.go Outdated Show resolved Hide resolved
david-vavra
david-vavra reviewed Sep 12, 2022
View reviewed changes
examples/prometheus/slo_exporter.yaml Show resolved Hide resolved
pkg/prometheus_ingester/prometheus_ingester.go Outdated Show resolved Hide resolved
pkg/prometheus_ingester/prometheus_ingester.go Outdated Show resolved Hide resolved
pkg/prometheus_ingester/prometheus_ingester.go Outdated Show resolved Hide resolved
pkg/prometheus_ingester/prometheus_ingester_test.go Outdated Show resolved Hide resolved
pkg/prometheus_ingester/headerRoundTripper.go Outdated Show resolved Hide resolved
FUSAKLA
FUSAKLA reviewed Oct 5, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Vlk, Ondrej added 3 commits October 6, 2022 12:34
refactor: prometheus ingester headers
cc60bcf 
* added method to get map of headers from httpHeaders field
* renamed httpHeader struct
chore: changelog
e14ff36
refactor: do not copy headers in headersRoundtripper
455774e
rudo-thomas
rudo-thomas requested changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@rudo-thomas rudo-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More Go/readability/UX nits. Otherwise LGTM.

pkg/prometheus_ingester/prometheus_ingester.go Outdated Show resolved Hide resolved
pkg/prometheus_ingester/prometheus_ingester.go Outdated Show resolved Hide resolved
pkg/prometheus_ingester/prometheus_ingester_test.go Show resolved Hide resolved
pkg/prometheus_ingester/prometheus_ingester_test.go Outdated Show resolved Hide resolved
pkg/prometheus_ingester/prometheus_ingester_test.go Outdated Show resolved Hide resolved
@FuFikCZ FuFikCZ merged commit e41bcb5 into master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FUSAKLA FUSAKLA FUSAKLA left review comments

@david-vavra david-vavra david-vavra left review comments

@rudo-thomas rudo-thomas rudo-thomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FuFikCZ @rudo-thomas @FUSAKLA @david-vavra