Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn for daylight savings time missing hours #421

Closed
wants to merge 3 commits into from

Conversation

billdenney
Copy link
Collaborator

Fix #420

@billdenney billdenney mentioned this pull request Jan 15, 2021
@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #421 (9bc5be3) into master (6f4a800) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #421   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          950       952    +2     
=========================================
+ Hits           950       952    +2     
Impacted Files Coverage Δ
R/excel_dates.R 100.00% <100.00%> (ø)

@billdenney
Copy link
Collaborator Author

Hmm, Windows and Mac work while Linux does not. This will take some investigation.

@billdenney
Copy link
Collaborator Author

This is included in #422 , so working on it there, only.

@billdenney billdenney closed this Jan 15, 2021
@billdenney billdenney deleted the fix-420 branch March 7, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

excel_numeric_to_date gives NA output for times in daylight savings time gap
1 participant