-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial separation of tabyl
#588
base: main
Are you sure you want to change the base?
Initial separation of tabyl
#588
Conversation
Nicely done! So first order of business is, get We are past due to fix #582 which was closed in #584. I wonder if I should just branch off the repo at 2.2.0 and cherry that one fix in, then submit to CRAN as 2.2.1. That should get a very fast review and maybe beat the holiday rush? |
Yeah, the first order of business is to get tabyl onto CRAN. I agree that this may be better after the janitor update, but if we are lucky, they may review tabyl quickly... Maybe? I think that we nearly have tabyl to a good state to be a separate package. Maybe try to push it when everything is cleaned up there and see if it (surprisingly) goes quickly? |
@sfirke, If some of the author(s) of |
…e' of https://github.com/sfirke/janitor into 240-breaking-off-tabyl-and-adorn_-into-their-own-package
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #588 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 27 15 -12
Lines 1413 826 -587
==========================================
- Hits 1413 826 -587
|
Before we re-import the I think that this means we will not get this PR into |
Fix #240
This PR should import all functions from
tabyl
before being committed. That will requiretabyl
being on CRAN.