Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate for --incompatible_disallow_ctx_resolve_tools #458

Closed
meteorcloudy opened this issue Sep 12, 2024 · 10 comments · Fixed by #459
Closed

Migrate for --incompatible_disallow_ctx_resolve_tools #458

meteorcloudy opened this issue Sep 12, 2024 · 10 comments · Fixed by #459

Comments

@meteorcloudy
Copy link
Contributor

See bazelbuild/bazel#22249

Usage in this repo:

graal_inputs, _ = ctx.resolve_tools(tools = [
resolved_graal,
] + extra_tool_deps)

rules_graalvm is used by Bazel itself, so this is blocking building Bazel with Bazel@HEAD (or upcoming Bazel 8.0).

@meteorcloudy
Copy link
Contributor Author

@sgammon

FYI @tjgq

@sgammon
Copy link
Owner

sgammon commented Sep 12, 2024

Thanks for the tag @meteorcloudy. I'll prioritize a fix for this one.

@meteorcloudy
Copy link
Contributor Author

Downstream failure is now revealed after fixing some other breakages: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/4130#0191fe2b-61de-4994-9e6a-d5ee92614f03

@tjgq
Copy link
Contributor

tjgq commented Sep 18, 2024

#459 fixes this.

@sgammon
Copy link
Owner

sgammon commented Sep 19, 2024

@tjgq Thank you kindly

@meteorcloudy
Copy link
Contributor Author

Thanks for the fix! @tjgq

@sgammon Can you push a new release to the BCR?

@sgammon
Copy link
Owner

sgammon commented Sep 19, 2024

@meteorcloudy It's in the works, yeah. Now that #467 is done, I intend to merge #451, perform some cleanup, publish, then add JVM 23, then publish again.

I plan to publish at 0.11.3 and 0.12.0 respectively. Sound good to you?

@meteorcloudy
Copy link
Contributor Author

SGTM, thanks!

@meteorcloudy
Copy link
Contributor Author

Gently ping~

@sgammon
Copy link
Owner

sgammon commented Sep 29, 2024

@meteorcloudy moving step by step ;) #476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants