Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constrained_json_whitespace_pattern to ServerArgs #1438

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

zifeitong
Copy link
Contributor

@zifeitong zifeitong commented Sep 16, 2024

CC @qeternity @max99x

Motivation

It's hard to find a single whitespace pattern that works for all models(see dottxt-ai/outlines#691). I think it's better to leave the choice to the users.

Related PR: #1277

Modifications

constrained_json_whitespace_pattern is added to ServerArgs with the default value set to None (uses outlines default value).

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@zifeitong zifeitong changed the title Add constrained_json_whitespace_pattern ServerArgs Add constrained_json_whitespace_pattern to ServerArgs Sep 16, 2024
@merrymercy merrymercy merged commit 93dffd6 into sgl-project:main Sep 16, 2024
11 checks passed
@zifeitong zifeitong deleted the json_schema branch September 17, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants