Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add should_use_tensor_core #2179

Merged
merged 6 commits into from
Dec 1, 2024
Merged

feat: add should_use_tensor_core #2179

merged 6 commits into from
Dec 1, 2024
+65 −19

Conversation

zhyncs
Copy link
Member

@zhyncs zhyncs commented Nov 25, 2024

Motivation

Modifications

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@zhyncs
Copy link
Member Author

zhyncs commented Nov 25, 2024

follow-up #2169

@zhyncs zhyncs requested a review from yzh119 November 25, 2024 11:59
@zhyncs zhyncs marked this pull request as draft November 25, 2024 12:13
@zhyncs zhyncs mentioned this pull request Dec 1, 2024
Merged
3 tasks
merrymercy
merrymercy approved these changes Dec 1, 2024
View reviewed changes
Copy link
Contributor

@merrymercy merrymercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us get this in first!

@zhyncs zhyncs marked this pull request as ready for review December 1, 2024 09:53
@zhyncs zhyncs changed the title feat: add should_use_tensor_cores feat: add should_use_tensor_core Dec 1, 2024
@zhyncs zhyncs merged commit 118b6af into main Dec 1, 2024
3 of 16 checks passed
@zhyncs zhyncs deleted the zhyncs/tc branch December 1, 2024 10:01
@zhyncs zhyncs mentioned this pull request Dec 1, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merrymercy merrymercy merrymercy approved these changes

@Ying1123 Ying1123 Awaiting requested review from Ying1123 Ying1123 is a code owner

@ispobock ispobock Awaiting requested review from ispobock ispobock is a code owner

@hnyls2002 hnyls2002 Awaiting requested review from hnyls2002 hnyls2002 is a code owner

@ByronHsu ByronHsu Awaiting requested review from ByronHsu ByronHsu is a code owner

@yzh119 yzh119 Awaiting requested review from yzh119

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhyncs @merrymercy