Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Pixtral model (Mistral) #2381

Closed
wants to merge 24 commits into from

Conversation

yixin-huang1
Copy link
Contributor

@yixin-huang1 yixin-huang1 commented Dec 7, 2024

Add support for mistralai/Pixtral ([Feature] Support mistralai/Pixtral #2351).

@merrymercy
Copy link
Contributor

I added you as a co-author in #2500, so your future commits will trigger CI automatically.
Can you fix the lint error? https://sgl-project.github.io/references/contributor_guide.html#format-your-code

@merrymercy
Copy link
Contributor

How did you test the correctness of this model locally? Did you compare the logits against HF implements, similar to this one? #2365 (comment)

test/srt/test_pixtral.py Outdated Show resolved Hide resolved
test/srt/test_pixtral.py Show resolved Hide resolved
test/srt/test_vision_openai_server.py Outdated Show resolved Hide resolved
@merrymercy merrymercy marked this pull request as draft December 30, 2024 02:14
@merrymercy
Copy link
Contributor

merrymercy commented Dec 30, 2024

This PR is wrong. Close this for now. Other contributors please feel free to take this task.

@merrymercy merrymercy closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants