Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor: update killall script #2391

Merged
merged 5 commits into from
Dec 7, 2024
Merged

minor: update killall script #2391

merged 5 commits into from
Dec 7, 2024

Conversation

zhyncs
Copy link
Member

@zhyncs zhyncs commented Dec 7, 2024

Motivation

Modifications

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@zhyncs
Copy link
Member Author

zhyncs commented Dec 7, 2024

image

ByronHsu
ByronHsu reviewed Dec 7, 2024
View reviewed changes
scripts/killall_sglang.sh Outdated Show resolved Hide resolved
@zhyncs zhyncs marked this pull request as draft December 7, 2024 19:48
@zhyncs
Copy link
Member Author

zhyncs commented Dec 7, 2024

image It's ok now

@zhyncs zhyncs changed the title fix: update killall script minor: update killall script Dec 7, 2024
zhyncs
zhyncs commented Dec 7, 2024
View reviewed changes
scripts/killall_sglang.sh Outdated Show resolved Hide resolved
@zhyncs zhyncs marked this pull request as ready for review December 7, 2024 20:19
@zhyncs zhyncs merged commit 75ae968 into main Dec 7, 2024
3 of 16 checks passed
@zhyncs zhyncs deleted the zhyncs/fix-oom branch December 7, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByronHsu ByronHsu ByronHsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhyncs @ByronHsu