Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[router] defer health checking to router init #2393

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

ByronHsu
Copy link
Collaborator

@ByronHsu ByronHsu commented Dec 8, 2024

Motivation

Defer the initial health waiting to the router, so in sglang_router.launch_router, it knows to launch router only after all workers are healthy

Modifications

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@ByronHsu ByronHsu requested a review from Ying1123 as a code owner December 8, 2024 01:25
@ByronHsu ByronHsu force-pushed the byhsu/worker-init-health-check branch from e49d3a1 to c955a89 Compare December 8, 2024 23:39
@ByronHsu ByronHsu force-pushed the byhsu/worker-init-health-check branch from c955a89 to c22bcfd Compare December 9, 2024 01:08
@ByronHsu ByronHsu merged commit 6387098 into main Dec 9, 2024
6 checks passed
@ByronHsu ByronHsu deleted the byhsu/worker-init-health-check branch December 9, 2024 01:17
@ByronHsu ByronHsu changed the title [router] add health checking in router init [router] defer health checking to router init Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant