Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Triton decoding kernel for long context #2394

Merged
merged 7 commits into from
Dec 8, 2024
Merged

Optimize Triton decoding kernel for long context #2394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c35838d
flash decoding draft
ispobock Dec 3, 2024
e9e7267
fix acc
ispobock Dec 3, 2024
1223a55
add args
ispobock Dec 7, 2024
dd4baa4
fix acc bug
ispobock Dec 8, 2024
35356f0
update ref
ispobock Dec 8, 2024
d42c098
Merge branch 'main' into flash-decoding
ispobock Dec 8, 2024
1be3d36
Merge branch 'main' into flash-decoding
merrymercy Dec 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions python/sglang/srt/layers/attention/triton_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ def __init__(self, model_runner: ModelRunner):
else:
self.reduce_dtype = torch.float16

self.num_kv_splits = model_runner.server_args.triton_attention_num_kv_splits
self.v_head_dim = model_runner.token_to_kv_pool.get_value_buffer(0).shape[-1]

self.forward_metadata = None

self.cuda_graph_max_seq_len = model_runner.model_config.context_len
Expand All @@ -53,10 +56,14 @@ def init_forward_metadata(self, forward_batch: ForwardBatch):
start_loc = torch.zeros_like(forward_batch.seq_lens, dtype=torch.int32)
start_loc[1:] = torch.cumsum(forward_batch.seq_lens[:-1], dim=0)

total_num_tokens = forward_batch.seq_lens_sum
attn_logits = torch.empty(
(self.num_head, total_num_tokens),
dtype=self.reduce_dtype,
(
forward_batch.batch_size,
self.num_head,
self.num_kv_splits,
self.v_head_dim + 1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this, we do not need to reduce the cuda graph max bs for deepseek models?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me verify it.

),
dtype=torch.float32,
device=self.device,
)

Expand All @@ -75,11 +82,8 @@ def init_cuda_graph_state(self, max_bs: int):
(max_bs,), dtype=torch.int32, device=self.device
)
self.cuda_graph_attn_logits = torch.empty(
(
self.num_head,
self.cuda_graph_max_total_num_tokens,
),
dtype=self.reduce_dtype,
(max_bs, self.num_head, self.num_kv_splits, self.v_head_dim + 1),
dtype=torch.float32,
device="cuda",
)

Expand Down Expand Up @@ -189,6 +193,7 @@ def forward_decode(
forward_batch.seq_lens,
attn_logits,
max_seq_len,
self.num_kv_splits,
layer.scaling,
layer.logit_cap,
)
Expand Down
Loading
Loading