Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce watchdog interval to 5s #2410

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

ByronHsu
Copy link
Collaborator

@ByronHsu ByronHsu commented Dec 8, 2024

Motivation

The current watchdog interval is 60s, which is a bit too long. Say if i want to gracefully terminate a idle sglang server by sending a TERM signal, it needs to wait around ~60s to take effect.

Modifications

This PR reduces the interval to 5s

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@ByronHsu
Copy link
Collaborator Author

ByronHsu commented Dec 8, 2024

@merrymercy let me know if you have any concerns

@merrymercy merrymercy merged commit 27f7bed into main Dec 9, 2024
17 checks passed
@merrymercy merrymercy deleted the byhsu/reduce-watchdog-interval branch December 9, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants