Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatible with PEP 440 #2435

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix: compatible with PEP 440 #2435

merged 1 commit into from
Dec 10, 2024

Conversation

zhyncs
Copy link
Member

@zhyncs zhyncs commented Dec 10, 2024

Motivation

Modifications

Checklist

  • Format your code according to the Contributor Guide.
  • Add unit tests as outlined in the Contributor Guide.
  • Update documentation as needed, including docstrings or example tutorials.

@zhyncs zhyncs merged commit 7310aed into main Dec 10, 2024
1 check passed
@zhyncs zhyncs deleted the zhyncs/fix branch December 10, 2024 22:48
@zhyncs
Copy link
Member Author

zhyncs commented Dec 10, 2024

twine check dist/*
Checking dist/sgl_kernel-0.0.2.post0+cu124-cp310-cp310-manylinux2014_x86_64.whl: PASSED

@zhyncs
Copy link
Member Author

zhyncs commented Dec 11, 2024

@yizhang2077 Due to PyPI's limitations, it's not possible to differentiate between CUDA versions. I plan to update only the CUDA 12.1 version on PyPI, while other versions like 11.8 and 12.4 can be updated in GitHub releases (especially 11.8 @ispobock please follow up). There's no need for a separate compilation for each Python version, compatibility with Python 3.9+ is sufficient, so there will ultimately be just one wheel package on PyPI.

@zhyncs
Copy link
Member Author

zhyncs commented Dec 12, 2024

update:
Slightly different from the previous description, to simplify, multiple Python version whl files are finally provided. I can later merge them into one compatible with Python 3.8+. CUDA 12.1 is used by default, which is fine for overseas users, but many users in mainland China may still be using CUDA 11.8.

https://pypi.org/project/sgl-kernel/#files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant