Make torch TP composable with torchao #2436
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The TP styles in PyTorch trunk performs a scatter from rank 0 to distribute a full tensor into DTensors.
While this is safer for training, it is unnecessary for inference where all ranks' weight already come from the same checkpoint. Therefore, we choose to do a local sharding instead of scatter.
Modifications
This PR customizes the TP styles impls to use
_shard_tensor
instead ofdistribute_tensor
.Worked configs:
Output:
Checklist