Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for torchao quant #2476

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Small fixes for torchao quant #2476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f70a14b
Small fixes for torchao quant
jerryzh168 Dec 13, 2024
a17dee0
Merge branch 'main' into some-fixes
zhyncs Dec 14, 2024
d068341
Merge branch 'main' into some-fixes
zhyncs Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion python/sglang/srt/layers/torchao_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,12 @@ def apply_torchao_config_to_model(
quantize_,
)
from torchao.quantization.observer import PerRow, PerTensor
from torchao.quantization.quant_api import _is_linear

if filter_fn is None:

def filter_fn(module, fqn):
return "proj" in fqn
return _is_linear(module) and "proj" in fqn

if torchao_config == "" or torchao_config is None:
return model
Expand Down
8 changes: 4 additions & 4 deletions python/sglang/srt/model_executor/model_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,10 @@ def __init__(
self.sampler = Sampler()
self.load_model()

apply_torchao_config_to_model(
self.model, global_server_args_dict["torchao_config"]
)

# Apply torch TP if the model supports it
supports_torch_tp = getattr(self.model, "supports_torch_tp", False)
if self.tp_size > 1 and supports_torch_tp:
Expand All @@ -165,10 +169,6 @@ def __init__(
else:
self.torch_tp_applied = False

apply_torchao_config_to_model(
self.model, global_server_args_dict["torchao_config"]
)

# Init memory pool and attention backends
if server_args.lora_paths is not None:
self.init_lora_manager()
Expand Down
Loading