Revert "Small fixes for torchao quant" #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8269947.
merrymercy
requested review from
Ying1123,
hnyls2002,
zhyncs and
ispobock
as code owners
jerryzh168
reviewed
Dec 16, 2024
|
|
||
| if filter_fn is None: | ||
|
|
||
| def filter_fn(module, fqn): | ||
| return _is_linear(module) and "proj" in fqn | ||
| return "proj" in fqn |
There was a problem hiding this comment.
@merrymercy this change? or the reordering of apply_torchao_config_to_model only works for torch native llama?
There was a problem hiding this comment.
I think it is this change. I reverted the whole change to make the CI passes.
There was a problem hiding this comment.
I picked the correct change in this PR #2495.
Please follow up with the correct fix for _is_linear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2476 because it only works for torch native llama