Don't require a serde dependency in consuming crates #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to serde_derive 1.0.90, there was no way for us to re-export
everything required for this derive to function without requiring that
all users of swirl have serde in their `Cargo.toml`. While it's probably
likely that anyone using this library is already using Serde, it's still
an arbitrary restriction.
Now we can re-export everything required from swirl directly. I've
specifically depended on `serde_derive` instead of `serde = { features
= ["derive"] }`, since we will only work with version 1.0.90 or later of
the derive crate, and serde does not have a strict version requirement
on the derive crate when the feature is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to serde_derive 1.0.90, there was no way for us to re-export
everything required for this derive to function without requiring that
all users of swirl have serde in their
Cargo.toml. While it's probablylikely that anyone using this library is already using Serde, it's still
an arbitrary restriction.
Now we can re-export everything required from swirl directly. I've
specifically depended on
serde_deriveinstead ofserde = { features = ["derive"] }, since we will only work with version 1.0.90 or later ofthe derive crate, and serde does not have a strict version requirement
on the derive crate when the feature is enabled.
Fixes #9