Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to homepage after adding a link via "Add Link" dialog #115

Closed
e2jk opened this issue Feb 18, 2015 · 8 comments · Fixed by #140
Closed

Redirect to homepage after adding a link via "Add Link" dialog #115

e2jk opened this issue Feb 18, 2015 · 8 comments · Fixed by #140
Assignees
Labels
easy good place to start contributing enhancement

Comments

@e2jk
Copy link

e2jk commented Feb 18, 2015

When I add a page to Shaarli, I usually do it one at a time. I do not use the bookmarklet, so my process goes as such:

  • I find an interesting page
  • I open my Shaarli page
  • I log in (sometimes I'm still logged in, but it is definitely not reliable...)
  • I click on Add Link
  • I paste the URL of the interesting page, and hit Save

Then I usually want to confirm that the addition worked, so I want to see the main page. But after having added a link, Shaarli brings me back again to the page to add a new link, so I need to click on the logo in the upper left part.

The question I want to ask the community is as follow: Do you see benefit/use the fact that after having added a new link, you are prompted to add a new one?

If it was just up to me, I'd have Shaarli redirect to the home page after adding a link, providing a visual confirmation that all worked fine.

What are your thoughts?

@nodiscc
Copy link
Member

nodiscc commented Feb 18, 2015

I agree, Shaarli should redirect to the home page after hitting Save when the previous page was ?do=addlink. Maybe we can use the HTTP referrer or the returnurl variable for this.

@pikzen
Copy link

pikzen commented Feb 18, 2015

Yup, redirecting to a new addlink page makes little sense to me. Redirecting to / seems to be the most logical thing to do.

@virtualtam
Copy link
Member

Could this be left for the user to choose? A simple Add an other link checkbox would do the trick :)

Let me explain:

  • +1 for home usage: add a link, go back to the home page;
  • -1 for work usage: I sometimes don't have access to Shaarli for a couple days (thanks to companies' overzealous proxy filtering policies); links then agglutinate in an e-mail draft before being all added at the same time... in which case cycling through home > add link > home > add link >... would just be a pain.

@nodiscc
Copy link
Member

nodiscc commented Feb 22, 2015

The checkbox idea is fine, valid usecase (batch adding links)

@e2jk
Copy link
Author

e2jk commented Feb 23, 2015 via email

@nodiscc
Copy link
Member

nodiscc commented Mar 3, 2015

allows you to paste one url per line, so that you could add X>1 links at once.

So what happens when you click Add link and have multiple links in the area? Does it send you to a series of editlink dialogs?

@nodiscc nodiscc changed the title Discussion/Qestion: Should Shaarli redirect to the home page after adding a new link? Should Shaarli redirect to the home page after adding a new link? Mar 3, 2015
@e2jk
Copy link
Author

e2jk commented Mar 4, 2015

I would suggest the template that is used to edit the links is repeated for each link.
I'd like to split this issue into 2 discussions:

  • One to redirect to the home page after adding a link (the original intent of this issue/question)
  • One to better support batch-adding links (which was raised as a potential downside to redirecting to the home page, and for which I think we can do better than serial copy/pasting into this single form).

@nodiscc
Copy link
Member

nodiscc commented Mar 4, 2015

Thanks @e2jk Let's redirect to the previous search first, just like we do after deleting a link. @virtualtam Please report a new bug for batch-adding links if you want.

@nodiscc nodiscc added easy good place to start contributing and removed discussion labels Mar 4, 2015
@nodiscc nodiscc self-assigned this Mar 4, 2015
@nodiscc nodiscc changed the title Should Shaarli redirect to the home page after adding a new link? Redirect to previous search after adding a link via "Add Link" dialog Mar 4, 2015
@nodiscc nodiscc changed the title Redirect to previous search after adding a link via "Add Link" dialog Redirect to homepage after adding a link via "Add Link" dialog Mar 4, 2015
@nodiscc nodiscc mentioned this issue Mar 4, 2015
Knah-Tsaeb pushed a commit to Knah-Tsaeb/myShaarli that referenced this issue May 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy good place to start contributing enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants