Refactor RSS feeds generation, and do it through templates #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Markdown plugin will be able to generate formatted feeds soon 😄 (cfr #485) |
| class FeedBuilder | ||
| { | ||
| /** | ||
| * @var string Constant: RSS feed type. |
There was a problem hiding this comment.
why the trailing dots at the end of each comment?
There was a problem hiding this comment.
Habits from my pro Sonar rules.
|
Very cool work @ArthurHoaro ! It's nice to see chunks of code drifting away from |
|
Thanks for the review! I'll work on it soon. |
ATOM feed improvement: * Adds a subtitle to match RSS feed behavior. * Better syntax for categories (see http://edward.oconnor.cx/2007/02/representing-tags-in-atom ). * Use locale to set the language
Improvements: * Add searchtags in categories domain URL. * Language is now based on the locale. * Add a generator tag. * self link is always displayed.
Minor changes: * Fix the date which was in a invalid format. * Avoid empty categories (tags). * Use the locale to set the language
…S feed. Create an example of the new hook in the demo plugin.
ArthurHoaro
force-pushed
the
template-feeds
branch
from
f3b3265 to
26c7b67
Compare
|
I've update the commit log to take your review into account. I've also added a new commit: 26c7b67
It's not really related to this PR, but it has to be done, and lighten the |
ArthurHoaro
force-pushed
the
template-feeds
branch
from
26c7b67 to
fe2f613
Compare
| * | ||
| * @return array Link array with feed attributes. | ||
| */ | ||
| public function buildItem($link, $pageaddr) |
There was a problem hiding this comment.
unless directly tested, can be either private or protected
|
Thanks 👍 |
|
Tested, works fine ;-) |
* search type now carried by LinkDB in order to factorize code between different search sources. * LinkDB->filter split in 3 method: filterSearch, filterHash, filterDay (we know what type of filter is needed). * filterHash now throw a LinkNotFoundException if it doesn't exist: internal implementation choice, still displays a 404. * Smallhash regex has been rewritten. * Unit tests update
ArthurHoaro
force-pushed
the
template-feeds
branch
from
fe2f613 to
528a6f8
Compare
|
Thanks again! |
alexisju
added a commit
to alexisju/albinomouse-template
that referenced
this pull request
Mar 27, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a bit huge, please look at the commit log to review it. I've tried to split everything in different commits to make it understandable.
To sum it up:
ENABLE_RSS_PERMALINKSsetting in administration has been reworded.Fixes #273
Note that this doesn't concern Daily RSS feed.
PS: tig is awesome.